Re: [PATCH] change the unpack limit treshold to a saner value

From: Linus Torvalds <torvalds@osdl.org>
Date: Dec 7, 2006, 03:39 UTC
Message-ID: <Pine.LNX.4.64.0612061935250.3615@woody.osdl.org>
In-Reply-To: <Pine.LNX.4.64.0612062213500.2630@xanadu.home>

On Wed, 6 Dec 2006, Nicolas Pitre wrote:

> 
> Note that this setting is currently observed for pushes not pulls.
> On the pull side you currentli need to provide -k for not exploding 
> packs.

So noted.

> So the question is what number of objects on average do pushes have?  If 
> most pushes are below the treshold this is not going to be really 
> useful.

It will depend a lot on the project, and "where" in the project you are.

For example, for most end developers, the "push" is likely going to be a few commits (say, a days work). Probably on the order of a few tens to maybe a few hundred objects. It's actually hard to create a pack with less than ten objects if you have a few directory levels (a single small commit in the kernel is usually 5-7 objects: commit + 2-3 levels of directory + a couple of blobs).

For me, as I pull a big merge and push it out, a push can easily be in the thousands of objects, just because I merged other peoples combined work over several weeks.

And for a "mirror" server, it will depend on the granularity of the mirroring.

> And I think 5000 is definitely way too high.  10 might be too small 
> indeed.  100 is maybe a good default to try out.

I think 100 is a nice round number for humans. Worth trying.