Re: [PATCH 2/2] Teach receive-pack how to keep pack files based on object count.

From: Nicolas Pitre <nico@cam.org>
Date: Oct 31, 2006, 19:56 UTC
Message-ID: <Pine.LNX.4.64.0610311447250.11384@xanadu.home>
In-Reply-To: <20061031075704.GB7691@spearce.org>

On Tue, 31 Oct 2006, Shawn Pearce wrote:

Show 5 quoted lines

> Since keeping a pushed pack or exploding it into loose objects
> should be a local repository decision this teaches receive-pack
> to decide if it should call unpack-objects or index-pack --stdin
> --fix-thin based on the setting of receive.unpackLimit and the
> number of objects contained in the received pack.

This works fine when used with my replacement patch for your [1/2] one.

> Currently this leaves every received pack as a kept pack.  We really
> don't want that as received packs will tend to be small.  Instead we
> want to delete the .keep file automatically after all refs have
> been updated.  That is being left as room for future improvement.

I think this should be solved before rx packs are actually stored as packs though. Otherwise people will end up with unwanted .keep files left around. Maybe having a much bigger default for object number treshold for the time being? (unless this patch is applied to "next" at the same time as another one that actually deals with those .keep files).