Re: [PATCH] add commit count options to git-shortlog
- From
Nicolas Pitre <nico@cam.org>
- Date
- Oct 10, 2006, 02:45 UTC
- Message-ID
- <Pine.LNX.4.64.0610092222030.2435@xanadu.home>
- In-Reply-To
- <7vodsotqqd.fsf@assigned-by-dhcp.cox.net>
On Sat, 7 Oct 2006, Junio C Hamano wrote:
Show 17 quoted lines
> Nicolas Pitre <nico@cam.org> writes: > > > This patch does 3 things: > >... > > Signed-off-by: Nicolas Pitre <nico@cam.org> > > > > --- > > > > I'm far from a Perl expert. I just hope that Perl gurus out there won't > > throw up too badly. > > > > With this it is possible to have nice statistics quickly, and > > demonstrate that Junio is really our King. ;-) > > I only talk passable Perl but I did not find much objectionable > stuff there. But I am not sure how this is useful aside from > stroking your own ego.
While stroking your own ego might sometimes be a good thing (hackers are in it for free because they have some pride back), I think it is most interesting for the pure statistic values. It is often nice to know who the main contributors are and by what margin, or to have a look at the contribution spectrum to have a feel of participation to a given project.
Linus recently wanted to know the opinion of an arbitrary number of top developers to the Linux kernel. He used a criteria to determine who those developers were which was based on amount of sign-off lines, but the number of pure contribution is otherwise the metric that most projects are likely to be interested in.
Oh, and BitKeeper had that feature.
Show 5 quoted lines
> Also I get the following. > > $ git log --pretty=short v1.4.2..abd6970 | > perl ./git-shortlog.perl -n -s >/dev/null > parse error: input records != output records
Please find new patch below (only one line added) with that issue fixed.
diff --git a/Documentation/git-shortlog.txt b/Documentation/git-shortlog.txt index 7486ebe..1601d22 100644 --- a/Documentation/git-shortlog.txt +++ b/Documentation/git-shortlog.txt @@ -7,16 +7,29 @@ git-shortlog - Summarize 'git log' outpu SYNOPSIS -------- -git-log --pretty=short | 'git-shortlog' +git-log --pretty=short | 'git-shortlog' [-h] [-n] [-s] DESCRIPTION ----------- Summarizes 'git log' output in a format suitable for inclusion -in release announcements. Each commit will be grouped by author +in release announcements. Each commit will be grouped by author and the first line of the commit message will be shown. Additionally, "[PATCH]" will be stripped from the commit description. +OPTIONS +------- + +-h:: + Print a short usage message and exit. + +-n:: + Sort output according to the number of commits per author instead + of author alphabetic order. + +-s: + Supress commit description and Provide a commit count summary only. + FILES ----- '.mailmap':: diff --git a/git-shortlog.perl b/git-shortlog.perl index 0b14f83..334fec7 100755 --- a/git-shortlog.perl +++ b/git-shortlog.perl @@ -1,6 +1,18 @@ #!/usr/bin/perl -w use strict; +use Getopt::Std; +use File::Basename qw(basename dirname); + +our ($opt_h, $opt_n, $opt_s); +getopts('hns'); + +$opt_h && usage(); + +sub usage { + print STDERR "Usage: ${\basename $0} [-h] [-n] [-s] < <log_data>\n"; + exit(1); +} my (%mailmap); my (%email); @@ -38,16 +50,38 @@ sub by_name($$) { uc($a) cmp uc($b); } +sub by_nbentries($$) { + my ($a, $b) = @_; + my $a_entries = $map{$a}; + my $b_entries = $map{$b}; + + @$b_entries - @$a_entries || by_name $a, $b; +} + +my $sort_method = $opt_n ? \&by_nbentries : \&by_name; + +sub summary_output { + my ($obj, $num, $key); + + foreach $key (sort $sort_method keys %map) { + $obj = $map{$key}; + $num = @$obj; + printf "%s: %u\n", $key, $num; + $n_output += $num; + } +} sub shortlog_output { - my ($obj, $key, $desc); + my ($obj, $num, $key, $desc); + + foreach $key (sort $sort_method keys %map) { + $obj = $map{$key}; + $num = @$obj; - foreach $key (sort by_name keys %map) { # output author - printf "%s:\n", $key; + printf "%s (%u):\n", $key, $num; # output author's 1-line summaries - $obj = $map{$key}; foreach $desc (reverse @$obj) { print " $desc\n"; $n_output++; @@ -152,7 +186,7 @@ sub finalize { &setup_mailmap; &changelog_input; -&shortlog_output; +$opt_s ? &summary_output : &shortlog_output; &finalize; exit(0);