git/list[1] front-page[2] threads[3] people[4] search[5] about
 

PATCH/RFC] allow delta data reuse even if base object is a preferred base

From
Nicolas Pitre <nico@cam.org>
Date
Sep 27, 2006, 19:42 UTC
Message-ID
<Pine.LNX.4.64.0609271536470.9349@xanadu.home>
Signed-off-by: Nicolas Pitre <nico@cam.org>
---
Any reason why this couldn't be done?

When I reworked that code I preserved the existing logic wrt preferred base. However I could not find a reason why it was that way. Hence this patch.

diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c
index 6db97b6..ee5f031 100644
--- a/builtin-pack-objects.c
+++ b/builtin-pack-objects.c
@@ -989,7 +988,7 @@ static void check_object(struct object_e
 		unuse_packed_git(p);
 		entry->in_pack_header_size = used;
 
-		if (base_entry && !base_entry->preferred_base) {
+		if (base_entry) {
 
 			/* Depth value does not matter - find_deltas()
 			 * will never consider reused delta as the
Next: Junio C Hamano
Message 1 of 2 in “PATCH/RFC] allow delta data reuse even if base object is a preferred base”
  1. Nicolas PitreSep 27, 2006
  2. Junio C HamanoSep 27, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.