RE: [PATCH] Build on Debian GNU/Hurd

From: Linus Torvalds <torvalds@osdl.org>
Date: Sep 21, 2006, 17:53 UTC
Message-ID: <Pine.LNX.4.64.0609211050390.4388@g5.osdl.org>
In-Reply-To: <000001c6dda4$ad0b1ec0$c47eedc1@ramsay1.demon.co.uk>

On Thu, 21 Sep 2006, Ramsay Jones wrote:

> 
> IMHO, setting the value in the Makefile, for systems that don't define
> PATH_MAX, is a much better solution. In fact, that is what I thought was
> already being done.

Well, considering that we _can_ test defines, why not just do it automatically.

In other words, instead of this patch:

Show 5 quoted lines

> >  -
> >  -#ifndef PATH_MAX
> >  -# define PATH_MAX 4096
> >  -#endif
> >  +#include <limits.h>

Just make the code read

	#include <limits.h>

	/*
	 * Insane systems don't have a fixed PATH_MAX, it's POSIX
	 * compliant but not worth worrying about, so if we didn't
	 * get PATH_MAX from <limits.h>, just make up our own
	 */
	#ifndef PATH_MAX
	# define PATH_MAX 4096
	#endif

and after that we can just ignore the issue forever more.

The thing is, it's not like we even really _care_ what PATH_MAX is all that deeply. We just want to get some random value that is reasonable.

		Linus