Re: [PATCH] Fix broken sha1 locking

From: Linus Torvalds <torvalds@osdl.org>
Date: Sep 19, 2006, 21:16 UTC
Message-ID: <Pine.LNX.4.64.0609191411460.4388@g5.osdl.org>
In-Reply-To: <20060919205823.18579.59604.stgit@machine.or.cz>

On Tue, 19 Sep 2006, Petr Baudis wrote:

Show 6 quoted lines

>
> Current git#next is totally broken wrt. cloning over HTTP, generating refs
> at random directories. Of course it's caused by the static get_pathname()
> buffer. lock_ref_sha1() stores return value of mkpath()'s get_pathname()
> call, then calls lock_ref_sha1_basic() which calls git_path(ref) which
> calls get_pathname() at that point returning pointer to the same buffer.

Hmm. This was exactly the schenario why I did commit e7676d2f6454c9c99e600ee2ce3c7205a9fcfb5f - allowing a couple of overlapping paths

Isn't that in the "next" branch too?

Of course, that still assumes that you strdup() the result at _some_ time, and can't just save it away, but lock_ref_sha1_basic() should do that.

			Linus