Re: [PATCH 13/19] gitweb: Add invisible hyperlink to from-file/to-file diff header

From: Linus Torvalds <torvalds@osdl.org>
Date: Aug 27, 2006, 03:38 UTC
Message-ID: <Pine.LNX.4.64.0608262033000.11811@g5.osdl.org>
In-Reply-To: <200608252105.07500.jnareb@gmail.com>

On Fri, 25 Aug 2006, Jakub Narebski wrote:

Show 5 quoted lines

>
> Change replacing hashes as from-file/to-file with filenames from
> difftree to adding invisible (except underlining on hover/mouseover)
> hyperlink to from-file/to-file blob.  /dev/null as from-file or
> to-file is not changed (is not hyperlinked).

Wouldn't it be even better to have the hyperlink (or a new, separate one) point to the history for that file, too?

That way, you can go to the commit-diff, and when you see a diff for a file, you can easily just ask for the whole history for that file. As it is, you can get that, but only by going to the "commit" thing, not from the "commit-diff" thing.

Alternatively, maybe commit-diff should have a header with the files it changes (ie it would truly be a superset of the "commit" case)? That might be even nicer, since you'd not have to scroll through a potentially big diff for other files in order to get to the one you care about.

(If you do the "header with changed files", each file could have the same three buttons as in the "commit" view: "blob" (pointing to the blob), "diff" (which just points to _within_ the current window, so that you can get to the start of that particular file diff) and "history" (which obviously does what the "commit" case does too - generate a history page).

			Linus