Re: Unresolved issues #3

From: Nicolas Pitre <nico@cam.org>
Date: Aug 18, 2006, 14:49 UTC
Message-ID: <Pine.LNX.4.64.0608181041420.11359@localhost.localdomain>
In-Reply-To: <44E546F2.7070902@gmail.com>

On Thu, 17 Aug 2006, A Large Angry SCM wrote:

Show 24 quoted lines

> Junio C Hamano wrote:
> ...
> > * "A Large Angry SCM" wrote a nice summary, "Git files data
> >   formats documentation".
> > 
> >   Message-ID: <44D51D47.9090700@gmail.com>
> > 
> >   With one final update by Nico yesterday, I think it is ready
> >   for inclusion.
> > 
> >   Does somebody care to make a patch out of it to add it to
> >   Documentation/technical/, maybe removing pack-format.txt there
> >   after making sure all it talks about is covered by the new
> >   documentation?
> > 
> >   I do not have enough "virginity" to spot omissions in the
> >   description anymore, so comments from somebody new to the
> >   system are very much appreciated.
> > 
> 
> Two things:
> 
> 1) I disagree with Nico's assessment that, other than his, there can not
> exist any type 2 packs that have bit 6 set to mean copy from result.

Care to explain why?

Since this code is mine I can tell you that no official GIT version ever produced such a pack. The code to make use of that bit was quite involving and the end result wasn't great at all so I never published said code. This is also why current GIT accepts both pack version 2 and 3 without any distinction using the same code in patch-delta.c on the basis that no version 2 packs ever used that bit.

Nicolas