Re: Kernel headers git tree

From: Linus Torvalds <torvalds@osdl.org>
Date: Jul 14, 2006, 01:05 UTC
Message-ID: <Pine.LNX.4.64.0607131800520.5623@g5.osdl.org>
In-Reply-To: <7v4pxlt3xg.fsf@assigned-by-dhcp.cox.net>

On Thu, 13 Jul 2006, Junio C Hamano wrote:

Show 5 quoted lines

> 
> I am not sure what function incparent() is trying to do with
> this:
> 
> 	git rev-list --max-count=1 --topo-order $1 -- .

Yeah, that looks strange.

The "--topo-order" in particular looks pointless, and just slows things down.

The default ordering from git-rev-list (and all other revision listing things, ie "git log" etc) _does_ guarantee that we never show a child before _one_ of its parents has been shown (although "parent" in this case may be the command line).

As such, "--max-count=1 --topo-order" is pointless if you only give one revision, because whether you use --topo-order or not, the first commit will always be the parent of all subsequent commits.

So --topo-order just makes things MUCH MUCH slower with no upsides.

But that thing is doubly strange, because it uses "." as a path specifier. If this is done in the top-most directory, that should mean "all changes", which in turn means that the whole thing should be equivalent to

	git rev-parse "$1^0"

since all commits should make _some_ change, and thus the first revision in the list should always be the top commit - the one you passed in as an argument.

			Linus