Re: git-fmt-merge-message problem..

From: Linus Torvalds <torvalds@osdl.org>
Date: Jul 13, 2006, 05:29 UTC
Message-ID: <Pine.LNX.4.64.0607122222310.5623@g5.osdl.org>
In-Reply-To: <7vlkqyw0om.fsf@assigned-by-dhcp.cox.net>

On Wed, 12 Jul 2006, Junio C Hamano wrote:

> 
> Yes, this is a simple mistranslation from Perl to C.  A patch
> will follow shortly.

On a similar vein, how about this?

I always end up editing the revert sentence by hand to make grammatical sense.

I think we always talk about "commit xyz".

We never talk about "xyz commit", except when we end up talking about a commit as a branch head (notably, I would say "the HEAD commit", or possibly "the top-of-master commit", but here $commit is a SHA1 name, not anything else).

Hmm?

		Linus

---

diff --git a/git-revert.sh b/git-revert.sh
index de8b5f0..2bf35d1 100755
--- a/git-revert.sh
+++ b/git-revert.sh
@@ -84,7 +84,7 @@ revert)
 		s/^[^ ]* /Revert "/
 		s/$/"/'
 	echo
-	echo "This reverts $commit commit."
+	echo "This reverts commit $commit."
 	test "$rev" = "$commit" ||
 	echo "(original 'git revert' arguments: $@)"
 	base=$commit next=$prev