Re: [PATCH] move get_merge_bases() to core lib; use it in merge-recursive

From: Linus Torvalds <torvalds@osdl.org>
Date: Jun 29, 2006, 18:26 UTC
Message-ID: <Pine.LNX.4.64.0606291123360.12404@g5.osdl.org>
In-Reply-To: <Pine.LNX.4.63.0606291814200.29667@wbgn013.biozentrum.uni-wuerzburg.de>

On Thu, 29 Jun 2006, Johannes Schindelin wrote:

> 
> My point being: it makes no sense to split off get_merge_bases() if nobody 
> uses it except for git-merge-base.

I disagree. Your get_merge_bases() function is another small step in cleanup and libification, so I think it's perfectly valid regardless of whether somebody uses it yet.

A lot of the libification effort ends up being preparatory, because often you need to get past a hump of libifying a _lot_ in order to actually use something in a library.

So at first, the only user is usually the old separate program. So you libify get_merge_bases, and initially the only user is git-merge-base, which could now be made a built-in, since the bulk of its code is going to be linked in regardless..

		Linus