Re: wrong check condition in patch-delta.c?

From: Nicolas Pitre <nico@cam.org>
Date: Jun 20, 2006, 12:28 UTC
Message-ID: <Pine.LNX.4.64.0606200827120.3377@localhost.localdomain>
In-Reply-To: <fcaeb9bf0606192332j5b2ee4b9ycf2c63c7b1820204@mail.gmail.com>

On Tue, 20 Jun 2006, Nguyn Thái Ngc Duy wrote:

Show 7 quoted lines

> Hi,
> While inspecting patch-delta.c, I encounter this:
>                       if (cp_off + cp_size < cp_size ||
>                           cp_off + cp_size > src_size ||
>                           cp_size > size)
>                               goto bad;
> "cp_off + cp_size < cp_size" doesn't make sense to me. Is it on purpose?

Yes, it absolutely is.

Nicolas