Re: Make "git rev-list" be a builtin

From: Linus Torvalds <torvalds@osdl.org>
Date: May 18, 2006, 22:00 UTC
Message-ID: <Pine.LNX.4.64.0605181454540.10823@g5.osdl.org>
In-Reply-To: <7vejyrngto.fsf@assigned-by-dhcp.cox.net>

On Thu, 18 May 2006, Junio C Hamano wrote:

Show 8 quoted lines

> Linus Torvalds <torvalds@osdl.org> writes:
> >
> > We should have done this long ago.
> 
> Should we have?
> 
> Certainly it is almost trivial, and it means we need to worry
> about one less file, but is that the point?

Take a look at the size of the binaries before and after.

This is the _stripped_ binaries (on ppc) before:

  -rwxr-xr-x 9 torvalds torvalds 213392 May 18 14:56 git
  -rwxr-xr-x 1 torvalds torvalds 167540 May 18 14:56 git-rev-list

and after:

  -rwxr-xr-x 10 torvalds torvalds 216740 May 18 14:56 git
  -rwxr-xr-x 10 torvalds torvalds 216740 May 18 14:56 git-rev-list

ie the "git" binary grew by about 3kB, and the "git-rev-list" binary shrank by about 164kB (because it now takes zero disk-space: it's the same as the git binary).

So on ppc, you win about 160kB of disk space from this (and much more if you don't strip the binaries - "git-rev-list" is over half a megabyte with the debugging info for me).

Now, x86 probably has less of that, because it's a denser instruction set, but I'd expect that to be in the 100kB range too.

			Linus