git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fix diff-delta bad memory access

From
Linus Torvalds <torvalds@osdl.org>
Date
May 10, 2006, 17:18 UTC
Message-ID
<Pine.LNX.4.64.0605101015060.3718@g5.osdl.org>
In-Reply-To
<Pine.LNX.4.64.0605100953090.3718@g5.osdl.org>
On Wed, 10 May 2006, Linus Torvalds wrote:
> 
> Yeah, that was totally bogus. It would re-allocate _part_ of an 
> allocation, but that allocation contained not just the index, but all the 
> hashes and the hash entries too!

Actually, no, you got that part right. Mea culpa. It really only ended up being a problem when the area was moved, since the pointers into that area weren't updated.

The alignment issue is real, but looking at the different structures, they'll all have pointers that end up being the real (and only) alignment constraint, so as a result, on any reasonable machine they all have the same alignment and things are fine.

Junio - pls apply Nico's patch asap. It's correct, and fixes a really nasty problem. And I'll withdraw my other worries as "not consequential".

		Linus
Previous: Linus TorvaldsNext: Nicolas Pitre
Message 3 of 7 in “fix diff-delta bad memory access”
  1. fix diff-delta bad memory accessNicolas Pitre, May 10, 2006
  2. Linus TorvaldsMay 10, 2006
  3. Linus TorvaldsMay 10, 2006
  4. Nicolas PitreMay 10, 2006
  5. Linus TorvaldsMay 10, 2006
  6. Nicolas PitreMay 10, 2006
  7. Nicolas PitreMay 10, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.