Re: [PATCH] binary patch.

From: Nicolas Pitre <nico@cam.org>
Date: May 5, 2006, 15:41 UTC
Message-ID: <Pine.LNX.4.64.0605051128100.28543@localhost.localdomain>
In-Reply-To: <7vy7xgzsiu.fsf@assigned-by-dhcp.cox.net>

On Fri, 5 May 2006, Junio C Hamano wrote:

> > Yeah, things still to be done are deflating both delta and
> > optionally perhaps use just deflate without delta for "new file"
> > codepath.

Show 9 quoted lines

> +	/* We could do deflated delta, or we could do just deflated two,
> +	 * whichever is smaller.
> +	 */
> +	delta = NULL;
> +	deflated = deflate_it(two->ptr, two->size, &deflate_size);
> +	if (one->size && two->size) {
> +		delta = diff_delta(one->ptr, one->size,
> +				   two->ptr, two->size,
> +				   &delta_size, deflate_size);

Here you probably want to use deflate_size-1 (deflate_size can't be 0).

> +		orig_size = delta_size;
> +		if (delta)
> +			delta = deflate_it(delta, delta_size, &delta_size);

Here you're leaking the original delta buffer memory.

Nicolas