Re: [RESEND] [PATCH] fix gitk with lots of tags

From: Linus Torvalds <torvalds@osdl.org>
Date: Apr 18, 2006, 18:38 UTC
Message-ID: <Pine.LNX.4.64.0604181132440.3701@g5.osdl.org>
In-Reply-To: <20060418180614.GA31543@blackbean.org>

On Tue, 18 Apr 2006, Jim Radford wrote:

> 
> I've gotten no reposnse from Paul on this patch[1].  If it seems ok to
> you, would you mind putting it in your queue for him?  I hate to see
> gitk die with "argument list too long" messages.  They're so 640k.

Don't do this patch. It's wrong.

However, this simpler patch might be ok.

It just depends on the fact that git-rev-list can parse everything that git-rev-parse used to do these days, and thus the git-rev-parse call really isn't needed any more (and if that isn't true for some odd argument, we should make it true).

So the only thing we need to do is to add the "--default HEAD" thing to the front of the argument list.

		Linus

---

diff --git a/gitk b/gitk
index 87e7162..5d95779 100755
--- a/gitk
+++ b/gitk
@@ -19,16 +19,7 @@ proc gitdir {} {
 proc parse_args {rargs} {
     global parsed_args
 
-    if {[catch {
-	set parse_args [concat --default HEAD $rargs]
-	set parsed_args [split [eval exec git-rev-parse $parse_args] "\n"]
-    }]} {
-	# if git-rev-parse failed for some reason...
-	if {$rargs == {}} {
-	    set rargs HEAD
-	}
-	set parsed_args $rargs
-    }
+    set parsed_args [concat --default HEAD $rargs]
     return $parsed_args
 }