Re: Solaris cloning woes partly diagnosed

From: Linus Torvalds <torvalds@osdl.org>
Date: Apr 2, 2006, 19:22 UTC
Message-ID: <Pine.LNX.4.64.0604021218490.3050@g5.osdl.org>
In-Reply-To: <29336.1144005022@lotus.CS.Berkeley.EDU>

On Sun, 2 Apr 2006, Jason Riedy wrote:

Show 13 quoted lines

> And Linus Torvalds writes:
>  - 
>  - I'd be willing to bet that it's the fact that we take signals.
> 
> Unfortunately, I'm too busy to check into this, but I've
> run into similar problems in the past.  Just takes a busy 
> file server.
> 
>  - We do, for example, expect that regular file writing not do that. At least 
>  - "write_sha1_from_fd()" will just do a "write()" without testing the error 
>  - return, [...]
> 
> There is an xwrite in git-compat-util.h...

Well, git itself is actually fairly good about these things. Right now I'm seriously suspecting Solaris stdio as being just horribly impolite.

git tends to not just use xwrite() in most places, but check the return value for partial sizes etc. I tried to grep for places where we were lazy, and there really seems to be just a very small handful, and they shouldn't impact this case at all (you have to have a seriously broken setup for them to matter, but we should fix them nonetheless.

		Linus