Re: Use a *real* built-in diff generator
- From
Linus Torvalds <torvalds@osdl.org>
- Date
- Mar 25, 2006, 15:36 UTC
- Message-ID
- <Pine.LNX.4.64.0603250734130.15714@g5.osdl.org>
- In-Reply-To
- <118833cc0603250544h289f385fo683ec7b40cdb0ed@mail.gmail.com>
On Sat, 25 Mar 2006, Morten Welinder wrote:
Show 8 quoted lines
> > The primary correctness concern is that patch understands > the output, ie., the libxdiff + patch brings out right back. > > It ought to be fairly easy to script checking every file change > that ever went into a git repository. You won't cover evil > cases that way, but it should provide some assurances that > nothing is too wrong.
I did _some_ tests, and especially "git-apply" is very useful, since it is actually a lot more anal than regular "patch".
It all worked fine except for files that don't end with a newline. Davide points out that he just forces the EOLN at the end in his test harness, but that's not exactly acceptable for a real project that actually has real cases.
I'll be taking a look at trying to fix it.
Linus