git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Don't recurse into parents marked uninteresting.

From
Linus Torvalds <torvalds@osdl.org>
Date
Mar 9, 2006, 05:48 UTC
Message-ID
<Pine.LNX.4.64.0603082144450.32577@g5.osdl.org>
In-Reply-To
<pan.2006.03.09.04.04.34.617873@smurf.noris.de>
On Thu, 9 Mar 2006, Matthias Urlichs wrote:
>
> revision.c:make_parents_uninteresting() is exponential with the number
> of merges in the tree. That's fine -- unless some other part of git
> already has pulled the whole commit tree into memory ...
Good call.

However, I would have expected the normal case to be that we haven't even parsed the parent yet (as per the comment), so the parent normally shouldn't even have the parent pointer (due to not having been parsed).

So what was it that triggered this "parents had already been parsed" situation? Is it because we've generated a huge list of "I have it" objects when pulling? That would explain it..

		Linus
Previous: Matthias UrlichsNext: smurf@smurf.noris.de
Message 3 of 4 in “endless loop: ?”
  1. Matthias UrlichsMar 8, 2006
  2. Don't recurse into parents marked uninteresting.Matthias Urlichs, Mar 9, 2006
  3. Linus TorvaldsMar 9, 2006
  4. smurf@smurf.noris.deMar 9, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.