git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's in git.git

From
Linus Torvalds <torvalds@osdl.org>
Date
Mar 5, 2006, 20:04 UTC
Message-ID
<Pine.LNX.4.64.0603051203060.13139@g5.osdl.org>
In-Reply-To
<7vwtf8fzvb.fsf@assigned-by-dhcp.cox.net>
On Sun, 5 Mar 2006, Junio C Hamano wrote:
Show 5 quoted lines
> 
> I abused SHOWN when I did --objects-edge with
> mark_edge_parents_uninteresting modification in
> eb38cc689e84a8fd01c1856e889fe8d3b4f1bfb4, but probably it can be
> modified to use SEEN.

Ahh, no. SEEN is different from SHOWN. SHOWN means that we've actually shown that commit, while SEEN just means that we've added it to the list (but it might be uninteresting, for example). I think you did exactly the right thing wrt SHOWN.

That said, the revision list walker should never see a SHOWN commit on the list, because it is the thing that sets SHOWN as it removes the entry from the list (and it should never get re-added, due to SEEN).

		Linus
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 14 in “What's in git.git”
  1. Junio C HamanoMar 5, 2006
  2. Junio C HamanoMar 5, 2006
  3. Linus TorvaldsMar 5, 2006
  4. Junio C HamanoMar 5, 2006
  5. Linus TorvaldsMar 5, 2006
  6. Linus TorvaldsMar 5, 2006
  7. Junio C HamanoMar 5, 2006
  8. Linus TorvaldsMar 5, 2006
  9. Junio C HamanoMar 5, 2006
  10. Martin LanghoffMar 5, 2006
  11. Alexandre JulliardMar 5, 2006
  12. Martin LanghoffMar 5, 2006
  13. Alexandre JulliardMar 5, 2006
  14. Junio C HamanoMar 5, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.