Re: [PATCH] fetch-clone progress: finishing touches.

From: Linus Torvalds <torvalds@osdl.org>
Date: Feb 12, 2006, 20:37 UTC
Message-ID: <Pine.LNX.4.64.0602121230370.3691@g5.osdl.org>
In-Reply-To: <7vslqpjq2q.fsf@assigned-by-dhcp.cox.net>

On Sat, 11 Feb 2006, Junio C Hamano wrote:

Show 5 quoted lines

> 
>  * While we are doing eye-candy, this makes the silence after
>    "Generating pack..." part a bit more bearable.
> 
>    Likes, dislikes, too-much's?

Too little, actually.

Your change makes

	git clone ssh://...

be silent again, until the download actually starts. The "isatty(2)" thing in git-pack-objects won't trigger, because it's actually a socket, not a tty ;/

ssh will only set up a pty pair if it starts an interactive shell, not if you use the "ssh host cmd" form.

		Linus