git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add git-annotate - a tool for annotating files with the revision and person that created each line in the file.

From
Linus Torvalds <torvalds@osdl.org>
Date
Feb 8, 2006, 19:09 UTC
Message-ID
<Pine.LNX.4.64.0602081058210.2458@g5.osdl.org>
In-Reply-To
<11394103753694-git-send-email-ryan@michonline.com>
On Wed, 8 Feb 2006, Ryan Anderson wrote:
> 
> I think this version is mostly ready to go.
Hmm.. I get
   [torvalds@g5 git]$ ./git-annotate Makefile
   fatal: 'e83c5163316f89bfbde7d9ab23ca2e25604af290^1..e83c5163316f89bfbde7d9ab23ca2e25604af290': No such file or directory
   Undefined subroutine &main::all_lines_claimed called at ./git-annotate line 124.

where that fatal error is because e83c51.. doesn't _have_ a parent, it's the root (so doing ^1 on it doesn't work).

After fixing the "all_lines_claimed" problem as outlined by Dscho, I get a lot of

	Skipping diff-parse - i = filelines)
and no actual output.

Doing it on a file that didn't exist in the root commit still have those "Skipping" messages, but at least it did actually output something.

However, what it output was clearly not correct, so there's still some tweaking to do.

For example, doing
	./git-annotate apply.c

annotates most of that file to Junio's commit 1c15afb9, which is totally incorrect, that commit actually only changed a few lines.

So it looks like there's still some work to be done on this..
			Linus
Previous: Andreas EricssonNext: Junio C Hamano
Message 15 of 19 in “Add git-annotate - a tool for annotating files with the revision and person that created each line in the file.”
  1. Add git-annotate - a tool for annotating files with the revision and person that created each line in the file.Ryan Anderson, Feb 8, 2006
  2. Peter EriksenFeb 8, 2006
  3. Johannes SchindelinFeb 8, 2006
  4. Franck Bui-HuuFeb 8, 2006
  5. Johannes SchindelinFeb 8, 2006
  6. Junio C HamanoFeb 8, 2006
  7. Ralf BaechleFeb 10, 2006
  8. Andreas EricssonFeb 10, 2006
  9. Fredrik KuivinenFeb 14, 2006
  10. Randal L. SchwartzFeb 8, 2006
  11. Andreas EricssonFeb 9, 2006
  12. Junio C HamanoFeb 9, 2006
  13. Franck Bui-HuuFeb 9, 2006
  14. Andreas EricssonFeb 9, 2006
  15. Linus TorvaldsFeb 8, 2006
  16. Junio C HamanoFeb 8, 2006
  17. Ryan AndersonFeb 8, 2006
  18. Junio C HamanoFeb 8, 2006
  19. Ryan AndersonFeb 10, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.