Re: [PATCH] do not open editor in dumb terminal

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Feb 5, 2006, 05:04 UTC
Message-ID: <Pine.LNX.4.64.0602042346380.25300@iabervon.org>
In-Reply-To: <7voe1msef0.fsf@assigned-by-dhcp.cox.net>

On Sat, 4 Feb 2006, Junio C Hamano wrote:

Show 7 quoted lines

> I know of an editor that works fine even when invoked with
> TERM=dumb, and I explicitly told programs to use it by exporting
> EDITOR environment variable with the name of that editor.  I am
> entitled to expect that programs honor that wish, instead of
> insulting me by saying "Hey dummy, you cannot run any editor on
> a dumb terminal".  Be the editor "emacsclient" or "ed", they
> both work fine for me, thank you ;-).

I think that "ed" is a bit too obscure as something for people to use interactively, and emacsclient is obviously not a sane default (since people might not be using emacs in server mode). Probably the right thing is to have it supply a default if the terminal isn't dumb, and abort with an error if there is no editor set after defaults are supplied.

(I think the only editors people use in dumb terminals these days are ones that do the editing somewhere else, although I'm not sure of that.)

	-Daniel
*This .sig left intentionally blank*