Re: [PATCH] Do not ignore errors during make check
- From
Linus Torvalds <torvalds@osdl.org>
- Date
- Dec 14, 2005, 23:38 UTC
- Message-ID
- <Pine.LNX.4.64.0512141535130.3292@g5.osdl.org>
- In-Reply-To
- <20051214210932.GA2642@kvasir.watson.ibm.com>
On Wed, 14 Dec 2005, Amos Waterland wrote:
> > check: > - for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i; done > + for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || break; done
Actually, you might be better off with just
sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) *.c
these days. It will cause some interesting warnings (it actually cross-checks things, and is unhappy about multiple "main()" declarations with different types ;), but especially with eventual libification it might even be a good idea to try to avoid global functions with the same names in different programs ("main", of course, is special, sparse is just too stupid to know).
Linus