git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Still unsafe: write_sha1_from_fd()

From
Linus Torvalds <torvalds@osdl.org>
Date
Oct 6, 2005, 22:26 UTC
Message-ID
<Pine.LNX.4.64.0510061520400.31407@g5.osdl.org>

I was looking over the object writing functions, and noticed that "write_sha1_from_fd()" writes its object directly into the final object name, which means that if it is interrupted with ^C at an inopportune time, it will leave a corrupt object behind.

The only user is apparently ssh-fetch, but especially since the input-fd is a network connection, it looks like it is not at all unlikely that this case will trigger - all it takes is somebody impatient waiting for a large object.

Ugh,
		Linus
Next: Junio C Hamano
Message 1 of 2 in “Still unsafe: write_sha1_from_fd()”
  1. Linus TorvaldsOct 6, 2005
  2. Junio C HamanoOct 6, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.