git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rerere should not repeat the earlier hunks in later ones

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Apr 4, 2007, 22:00 UTC
Message-ID
<Pine.LNX.4.63.0704042359470.4045@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<7v8xd83sfn.fsf@assigned-by-dhcp.cox.net>
Hi,
On Wed, 4 Apr 2007, Junio C Hamano wrote:
Show 23 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > I wonder if we should also do
> >
> > diff --git a/builtin-rerere.c b/builtin-rerere.c
> > index b8867ab..4eae27b 100644
> > --- a/builtin-rerere.c
> > +++ b/builtin-rerere.c
> > @@ -112,7 +112,8 @@ static int handle_file(const char *path,
> >  		else if (!prefixcmp(buf, ">>>>>>> ")) {
> >  			hunk_no++;
> >  			hunk = 0;
> > -			if (memcmp(one->ptr, two->ptr, one->nr < two->nr ?
> > +			if (one->nr > two->nr || memcmp(one->ptr, two->ptr,
> > +						one->nr < two->nr ?
> >  						one->nr : two->nr) > 0) {
> >  				struct buffer *swap = one;
> >  				one = two;
> >
> > in case that one conflicting region is prefix of the other one.
> 
> If one is not a prefix of two but simply longer what does that
> code do?

You're right. With the eager merging algorithm, it is no longer possible that one side is a strict prefix of the other.

So please forget about my comment.

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 7 in “rerere should not repeat the earlier hunks in later ones”
  1. rerere should not repeat the earlier hunks in later onesJunio C Hamano, Apr 3, 2007
  2. Johannes SchindelinApr 4, 2007
  3. Junio C HamanoApr 4, 2007
  4. rerere: make sorting really stable.Junio C Hamano, Apr 4, 2007
  5. Johannes SchindelinApr 4, 2007
  6. Junio C HamanoApr 4, 2007
  7. Johannes SchindelinApr 5, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.