Re: Libification project (SoC)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 19, 2007, 12:37 UTC
Message-ID: <Pine.LNX.4.63.0703191329220.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <e5bfff550703190001k761541c7v2c259ef3f7695b10@mail.gmail.com>

Hi,

On Mon, 19 Mar 2007, Marco Costalba wrote:

Show 10 quoted lines

> On 3/19/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > 
> > I don't see _any_ problem in making an API which works with _one_ repo
> > first. This has several advantages:
> > 
> > - most users (if any!) will work that way,
> > 
> 
> Sometime could be useful to write a list of possible users before
> starting to code.

Fair enough.

I expect the most visible users of libgit to be: the core Git programs! Because if we don't eat our own dog food, why should anybody else?

And I am absolutely utterly opposed to make them slower just to support a program which wants to cache meta data from multiple repositories.

Yes, you could write a program which can compare objects from several repos, but that is easy in fact: just set GIT_ALTERNATE_OBJECT_DIRECTORIES and you're done. Without changing the core of Git at all!

Having said that, I never liked the idea of having static variables to talk with config handlers, and would have preferred cb_data like for_each_ref() does. That is a low hanging fruit, which does not affect performance, and is _definitely_ a clean up.

I am not so sure about the impact of changing the index to a non-static structure.

Ciao, Dscho