Re: [PATCH] Makefile: do not optimize when DEBUG=1

From

Johannes Schindelin <johannes.schindelin@gmx.de>

Date

Mar 7, 2007, 12:37 UTC

Message-ID

<Pine.LNX.4.63.0703071319520.22628@wbgn013.biozentrum.uni-wuerzburg.de>

In-Reply-To

<45EE854E.210EDAFF@eudaptics.com>

Hi,

On Wed, 7 Mar 2007, Johannes Sixt wrote:

> Johannes Schindelin wrote:
> > You can do that now by removing just the object files containing the
> > code you want to debug, and saying "make DEBUG=1".
> > [...]
> > -CFLAGS = -g -O2 -Wall
> > +CFLAGS = -g -Wall
> > +ifndef DEBUG
> > +       CFLAGS += -O2
> > +endif
> 
> I think the shortcut to remove just the interesting object file does not 
> work because Makefile notices (the GIT-CFLAGS rule) that there are "new 
> flags or prefix", and so recompiles everything.

I do something completely different now:

@@ -846,7 +841,8 @@ TRACK_CFLAGS = $(subst ','\'',$(ALL_CFLAGS)):\
 
 GIT-CFLAGS: .FORCE-GIT-CFLAGS
 	@FLAGS='$(TRACK_CFLAGS)'; \
-	    if test x"$$FLAGS" != x"`cat GIT-CFLAGS 2>/dev/null`" ; then \
+	    if test x"$$FLAGS" != x"`cat GIT-CFLAGS 2>/dev/null`" -a \
+		    -z "$(IGNORE_GIT_CFLAGS)"; then \
 		echo 1>&2 "    * new build flags or prefix"; \
 		echo "$$FLAGS" >GIT-CFLAGS; \
             fi

... and in my config.mak, there is

ifdef DEBUG
	ALL_CFLAGS := $(filter-out -O2,$(ALL_CFLAGS))
	IGNORE_GIT_CFLAGS = YesPlease
endif

I'm happy now.

Ciao,
Dscho