Re: Replacement for cvs2cl, for generating ChangeLog

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 27, 2007, 15:56 UTC
Message-ID: <Pine.LNX.4.63.0702271648430.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <200702271257.37437.andyparkins@gmail.com>

Hi,

On Tue, 27 Feb 2007, Andy Parkins wrote:

Show 5 quoted lines

> [...] perhaps a change to git's own log generator to support
> 
>  git-rev-list --pretty=gnucl
> 
> would be more appropriate.

I was already hacking on a builtin changelog command, because I was convinced that this breaks our model in builtin-log: We show the commit information first, and _then_ we call the diff machinery. And GNU ChangeLog format mixes these informations: the date and the author are commit information, but the files are tree information, and the oneline is commit information again.

However, your mail made me think again.

I now reused (AKA misused) the stats separator to take the oneline description, which is set in show_log() when revs->commit_format == CMIT_FMT_CHANGELOG, which is output by diff_flush() when the diff_options->output_format == DIFF_FORMAT_CHANGELOG.

BTW I already found a subtle bug. In finalize_changelog(), options->stat_sep can be NULL, if no oneline was found.

But AFAIK we do not allow empty commit messages, so this bug would never have been triggered.

Ciao, Dscho