Re: Increase some limits in git-mailinfo

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 26, 2007, 20:43 UTC
Message-ID: <Pine.LNX.4.63.0702262135140.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <Pine.LNX.4.64.0702261221530.12485@woody.linux-foundation.org>

Hi,

On Mon, 26 Feb 2007, Linus Torvalds wrote:

Show 11 quoted lines

> On Mon, 26 Feb 2007, Johannes Schindelin wrote:
> > 
> > > So I'd rather have it return true if it matches, rather than false 
> > > if it matches and -1/1 if it doesn't. But that's water under the 
> > > bridge.
> > 
> > In that case, you'd have to name it has_prefix() or hasprefix() rather 
> > than prefixcmp(), which C programmers used to the semantics of 
> > strcmp() expect to return a tristate result.
> 
> Sure. Or "match_prefix()" or whatever. I agree.

Well, if you look at fnmatch(), or our own match_pathspec(), rather not...

Just my 2 cents: I can live with prefixcmp(). And since I use strcmp() to compare strings, not strings_eq() or similar, I am quite happy with prefixcmp(), too.

Ciao, Dscho