Re: [PATCH] Add test-chmtime: a utility to change mtime on files

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 25, 2007, 01:27 UTC
Message-ID: <Pine.LNX.4.63.0702250220130.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <11723651923476-git-send-email-normalperson@yhbt.net>

Hi,

On Sat, 24 Feb 2007, Eric Wong wrote:

> This is intended to be a portable replacement for our usage
> of date(1), touch(1), and Perl one-liners in tests.

This is a cute idea!

Show 10 quoted lines

> diff --git a/Makefile b/Makefile
> index e51b448..105f3ec 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -829,7 +829,7 @@ GIT-CFLAGS: .FORCE-GIT-CFLAGS
>  
>  export NO_SVN_TESTS
>  
> -test: all
> +test: all test-chmtime$X

That is nice! This says that the program should be only compiled before running the tests. However, you can run the tests also by "cd t; make", and even by "cd t; sh tDDDD-*.sh", so I think a check in the tests should be added, which tests for executability of test-chmtime.

Ciao, Dscho