Re: [PATCH] git-bundle: assorted fixes
Hi,
On Thu, 22 Feb 2007, Mark Levedahl wrote:
Show 6 quoted lines
> Johannes Schindelin wrote:
>
> I built this under cygwin, it is running but I find two regressions compared
> to my git-bundle.sh:
>
> 1) git bundle create --all <whatever>
Are you sure you did not provide a bundle filename?
But indeed, my test shows that "--all" does not leave any refs. Bad.
This fixes it:
-- snip --
revision.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/revision.c b/revision.c
index 4cf697e..823bbd1 100644
--- a/revision.c
+++ b/revision.c
@@ -480,7 +480,7 @@ static int handle_one_ref(const char *path, const unsigned char *sha1, int flag,
struct all_refs_cb *cb = cb_data;
struct object *object = get_reference(cb->all_revs, path, sha1,
cb->all_flags);
- add_pending_object(cb->all_revs, object, "");
+ add_pending_object(cb->all_revs, object, path);
return 0;
}
-- snap --
but I think this adds a memory leak, and I don't know what else is
affected by it.
> 2) git bundle verify reports only a single sha1 if prerequisites are not
> met.
With the two follow-up patches I sent, this issue should be resolved, no?
Ciao,
Dscho
Johannes Schindelin <johannes.schindelin@gmx.de>