Re: [PATCH] Teach git-diff{,-files} the new option `--no-index`
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 22, 2007, 20:47 UTC
- Message-ID
- <Pine.LNX.4.63.0702222146280.22628@wbgn013.biozentrum.uni-wuerzburg.de>
- In-Reply-To
- <7vd542dji4.fsf@assigned-by-dhcp.cox.net>
Hi,
On Thu, 22 Feb 2007, Junio C Hamano wrote:
Show 17 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > >> For one thing, I want to move read_cache() out of run_diff_files() and > >> run_diff_index() to their callers, so that the caller can use a > >> handcrafted active_cache[] that is somewhat different from what > >> read_cache() originally read. > > > > I don't understand. Would it not be easier to "return active_nr" in > > read_cache_from(path) _also_ when active_cache is set? Or alternatively > > check if active_alloc is set? > > I do not understand your questions. > > What I am getting at is that in the current code (without your > patch), run_diff_files() is about diff between $GIT_DIR/index > and working tree. I want to make it diff between active_cache[] > and working tree.
My point was: you could just ignore the read_cache() calls if they just returned, doing nothing, as long as there is an active_cache.
But that's probably too dirty.
Anyway, I restructured the patch as per your comments, and will send it after this mail.
Ciao, Dscho