git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Teach git-diff{,-files} the new option `--no-index`

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 22, 2007, 20:47 UTC
Message-ID
<Pine.LNX.4.63.0702222146280.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<7vd542dji4.fsf@assigned-by-dhcp.cox.net>
Hi,
On Thu, 22 Feb 2007, Junio C Hamano wrote:
Show 17 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> >> For one thing, I want to move read_cache() out of run_diff_files() and 
> >> run_diff_index() to their callers, so that the caller can use a 
> >> handcrafted active_cache[] that is somewhat different from what 
> >> read_cache() originally read.
> >
> > I don't understand. Would it not be easier to "return active_nr" in 
> > read_cache_from(path) _also_ when active_cache is set? Or alternatively 
> > check if active_alloc is set?
> 
> I do not understand your questions.
> 
> What I am getting at is that in the current code (without your
> patch), run_diff_files() is about diff between $GIT_DIR/index
> and working tree.  I want to make it diff between active_cache[]
> and working tree.

My point was: you could just ignore the read_cache() calls if they just returned, doing nothing, as long as there is an active_cache.

But that's probably too dirty.

Anyway, I restructured the patch as per your comments, and will send it after this mail.

Ciao, Dscho

Previous: Junio C HamanoNext: Johannes Schindelin
Message 10 of 13 in “Teach git-diff{,-files} the new option `--no-index`”
  1. Teach git-diff{,-files} the new option `--no-index`Johannes Schindelin, Feb 20, 2007
  2. Junio C HamanoFeb 22, 2007
  3. Johannes SchindelinFeb 22, 2007
  4. Junio C HamanoFeb 22, 2007
  5. Johannes SchindelinFeb 22, 2007
  6. run_diff_files(): add option to prevent --no-indexJohannes Schindelin, Feb 22, 2007
  7. Junio C HamanoFeb 22, 2007
  8. Johannes SchindelinFeb 22, 2007
  9. Junio C HamanoFeb 22, 2007
  10. Johannes SchindelinFeb 22, 2007
  11. Teach git-diff-files the new option `--no-index`Johannes Schindelin, Feb 22, 2007
  12. Junio C HamanoFeb 23, 2007
  13. Johannes SchindelinFeb 23, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.