Re: [PATCH] rev-list --max-age, --max-count: support --boundary

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 20, 2007, 00:27 UTC
Message-ID: <Pine.LNX.4.63.0702200126180.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7v8xet67j3.fsf@assigned-by-dhcp.cox.net>

Hi,

On Mon, 19 Feb 2007, Junio C Hamano wrote:

Show 21 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > @@ -1336,7 +1342,17 @@ struct commit *get_revision(struct rev_info *revs)
> >  	case -1:
> >  		break;
> >  	case 0:
> > -		return NULL;
> > +		if (revs->boundary) {
> > +			struct commit_list *list = revs->commits;
> > +			while (list) {
> > +				list->item->object.flags |=
> > +					BOUNDARY_SHOW | BOUNDARY;
> > +				list = list->next;
> > +			}
> > +			revs->max_count = -1;
> > +			revs->limited = 1;
> > +		} else
> > +			return NULL;
> 
> The resetting of max_count and limited probably needs some
> commenting.

Right. Could you --amend with this, if you find it sufficient?

---

 revision.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/revision.c b/revision.c
index 87aea9c..be57191 100644
--- a/revision.c
+++ b/revision.c
@@ -1349,6 +1349,7 @@ struct commit *get_revision(struct rev_info *revs)
 					BOUNDARY_SHOW | BOUNDARY;
 				list = list->next;
 			}
+			/* all remaining commits are boundary commits */
 			revs->max_count = -1;
 			revs->limited = 1;
 		} else