Re: removal of "percent done" messages from git pull

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 19, 2007, 15:12 UTC
Message-ID: <Pine.LNX.4.63.0702191611410.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <tnxr6sm5m2u.fsf@arm.com>

Hi,

On Mon, 19 Feb 2007, Catalin Marinas wrote:

Show 12 quoted lines

> Larry Streepy <larry@lightspeed.com> wrote:
> > I run a nightly script to build and test our product.  I capture all
> > the output and email it to interested parties.  One very annoying
> > thing is the "percent done" messages that come out of git pull.  It
> > results in log files that look like this:
> [...]
> > I have found no way to make these messages go away.  When running in a
> > "batch" mode, IMHO, interactive messages like these should not be
> > emitted. At least there should be a switch to suppress them.
> 
> Or (as done in StGIT for some messages), only print those interactive
> messages when stdout is a tty, i.e. "if (isatty(1))".

You mean something like this?

-- [PATCH] fetch: make things quiet when not outputting to a tty

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>

---

 fetch-pack.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fetch-pack.c b/fetch-pack.c
index c787106..9ec5479 100644
--- a/fetch-pack.c
+++ b/fetch-pack.c
@@ -725,6 +725,8 @@ int main(int argc, char **argv)
 		nr_heads = argc - i - 1;
 		break;
 	}
+	if (!verbose && !isatty(1))
+		quiet = 1;
 	if (!dest)
 		usage(fetch_pack_usage);
 	pid = git_connect(fd, dest, uploadpack);