Re: [PATCH 1/2] Add `struct object_hash`

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Using object_hash, you can store interesting information about
> > objects in a private hash map. This makes up for the lack of a
> > `util` member of `struct object`.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >
> > 	We should have done that earlier. Now, git.git already
> > 	contains two specialised versions of an object hash map:
> > 	obj_hash and refs_hash.
> >
> > 	obj_hash is not really a hash map, but rather a hash set,
> > 	but there is no excuse for refs_hash having its own little
> > 	private implementation nobody else can reuse.
> 
> Ok, having now looked at it more, I can say:
> 
>  - I hate it.
> 
> I dislike it intensely, because it's so _close_ to being usable.