Re: mingw, windows, crlf/lf, and git

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 12, 2007, 23:24 UTC
Message-ID: <Pine.LNX.4.63.0702130020450.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vps8f6l81.fsf@assigned-by-dhcp.cox.net>

Hi,

On Mon, 12 Feb 2007, Junio C Hamano wrote:

> I agree that we can assume editors can grok files with LF end-of-line 
> just fine and we would not need to do the reverse conversion on checkout 
> paths (e.g. "read-tree -u", "checkout-index").

In that case, a simple pre-commit hook would suffice.

No, the problem mentioned by Mark was a very real one: you _cannot_ rely on Windows' editors not to fsck up with line endings. The worst case is if the file contains _some_ CRLF and _some _LF_. Almost always I had the problem that it now converted _all_ LFs to CRLFs. Even those which already were converted.

So, if we are to support text mode, it is not one-way. If we do one-way, we really do _not_ support text mode, but pre-commit conversion to LF style text. And in this case, core git does not need _any_ change.

Ciao, Dscho