Re: [PATCH] Makefile: add clean-obsolete-scripts target

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 11, 2007, 08:22 UTC
Message-ID: <Pine.LNX.4.63.0701110919040.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vhcuyaaxq.fsf@assigned-by-dhcp.cox.net>

Hi,

On Wed, 10 Jan 2007, Junio C Hamano wrote:

Show 10 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Cygwin, newly builtins are not recognized, because there exist both
> > the executable binaries (with .exe extension) _and_ the now-obsolete
> > scripts (without extension), but the script is executed.
> >
> > "make clean-obsolete-scripts" removes these ambiguities by removing the
> > older of these file pairs.
> 
> I would prefer it to be rather automatic -- how about this instead?

I like your method better. However, does it execute an rm -f for _every_ builtin, even if it does not exist? This is a huge performance eater on cygwin. Every fork() is _expensive_.

Even worse: are you sure that it does not remove the _builtins_? Maybe you noticed that I asked for "git-bla." instead of "git-bla", since the latter will happily access "git-bla.exe" (at least when you do an "ls git-bla" and "git-bla.exe" exists, but not "git-bla", it _will_ show the metadata of "git-bla.exe", but with the name "git-bla").

Will test.

Ciao, Dscho