Re: [PATCH] Auto-quote config values in config.c:store_write_pair()
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 9, 2007, 10:29 UTC
- Message-ID
- <Pine.LNX.4.63.0701091128170.22628@wbgn013.biozentrum.uni-wuerzburg.de>
- In-Reply-To
- <20070109052741.GB27927@Hermes.local>
Hi,
On Tue, 9 Jan 2007, Brian Gernhardt wrote:
Show 11 quoted lines
> + if (quote)
> + write(fd, "\"", 1);
> for (i = 0; value[i]; i++)
> switch (value[i]) {
> case '\n': write(fd, "\\n", 2); break;
> @@ -508,6 +520,8 @@ static void store_write_pair(int fd, const char* key, const char* value)
> case '"': case '\\': write(fd, "\\", 1);
> default: write(fd, value+i, 1);
> }
> + if (quote)
> + write(fd, "\"", 1);AFAICS this misses the case where you have to quote a single '"'.
Ciao, Dscho