Re: [PATCH] Replacing the system call pread() with real mmap().

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 7, 2007, 17:10 UTC
Message-ID: <Pine.LNX.4.63.0701071810220.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <20070107163637.GE9909@scotty.home>

Hi,

On Sun, 7 Jan 2007, Stefan-W. Hahn wrote:

Show 11 quoted lines

> Also sprach Shawn O. Pearce am Sun, 07 Jan 2007 at 06:24:45 -0500:
> > Better to emulate pread using lseek/xread/lseek:
> > 
> > 	off_t p = lseek(fd, offset, SEEK_SET);
> > 	xread(fd, buf, count);
> > 	lseek(fd, p, SEEK_SET);
> > 
> > If you look at the history for contrib/mmap.c you will see an
> > implementation like that before it was called git_mmap().
> 
> This doesn't work;I tried it before.

Care to elaborate? It worked pretty well on _all_ cygwin setups I tested with.

Ciao, Dscho