Re: [PATCH 2/2] git-commit-tree: if i18n.commitencoding is utf-8 (default), check it

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 22, 2006, 22:21 UTC
Message-ID: <Pine.LNX.4.63.0612222320580.19693@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vy7ozwqf5.fsf@assigned-by-dhcp.cox.net>

Hi,

On Fri, 22 Dec 2006, Junio C Hamano wrote:

Show 16 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Now, git-commit-tree refuses to commit when i18n.commitencoding is
> > either unset, or set to "utf-8", and the commit message does not
> > minimally conform to the UTF-8 encoding.
> >
> > Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> > ---
> >
> > 	Unfortunately, I could not think of a shorter oneline description. 
> > 	But my next patch fixes at least the output in shortlog.
> 
> I think the rule that you described on the one-line description
> makes more sense than "either unset of set to utf-8".  In other
> words, I'd prefer doing this in a repository that explicitly
> asks for it.

Well, the problem is this line:

environment.c:21:char git_commit_encoding[MAX_ENCODING_LENGTH] = "utf-8";

> I do not want to get burned by too many incompatible changes X-<.

Understandable.

Ciao, Dscho