Re: [PATCH] Adjust t5510 to put remotes in config

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 18, 2006, 22:28 UTC
Message-ID: <Pine.LNX.4.63.0612182325550.19693@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7v7iwox59i.fsf@assigned-by-dhcp.cox.net>

Hi,

On Mon, 18 Dec 2006, Junio C Hamano wrote:

Show 5 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Since .git/remotes/ is no longer created by default, t5510 failed.
> 
> Does not reproduce for me.

I just checked out a fresh copy of 'next'. It still fails. The culprit is 61dde8f91672ab362f3cfd3af8d6d09d448d4ffe, which removes the line

		mkdir -p "$GIT_DIR/remotes" &&

which is line 372 in the parent of that commit.

Show 5 quoted lines

> > While at it, convert the tests to use the config way of specifying
> > remotes instead of creating a file in .git/remotes/.
> 
> I think adding tests to use config is good, but I'd rather see
> the test scripts to test not _only_ config but both.

Okay. How about fixing the first hunk as proposed, and the second by 'mkdir .git/remotes'?

Ciao, Dscho