git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Remove uncontested renamed files during merge.

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 13, 2006, 10:31 UTC
Message-ID
<Pine.LNX.4.63.0612131129550.3635@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<20061213095540.GA25001@spearce.org>
Hi,
On Wed, 13 Dec 2006, Shawn O. Pearce wrote:
Show 19 quoted lines
> Prior to 65ac6e9c3f47807cb603af07a6a9e1a43bc119ae we deleted a
> file from the working directory during a merge if the file existed
> in the working directory before the merge started but was renamed
> by the branch which is being merged in.  This broke in 65ac63 as
> git-merge-recursive did not actually update the working directory
> on this uncontested rename case.
> 
> [...]
>
> diff --git a/merge-recursive.c b/merge-recursive.c
> index 9d53bcd..741d17f 100644
> --- a/merge-recursive.c
> +++ b/merge-recursive.c
> @@ -873,7 +873,7 @@ static int process_renames(struct path_list *a_renames,
>  			struct diff_filespec src_other, dst_other;
>  			int try_merge, stage = a_renames == renames1 ? 3: 2;
>  
> -			remove_file(1, ren1_src, 1);
> +			remove_file(1, ren1_src, 0);

I _think_ that the "0" should be "!index_only". After all, these functions are not only called on the virtual merges, but also on the final merge, which indeed should update the working directory. And since it is a rename, the old file has to go.

Ciao,
Previous: Shawn O. PearceNext: Shawn Pearce
Message 2 of 4 in “Remove uncontested renamed files during merge.”
  1. Remove uncontested renamed files during merge.Shawn O. Pearce, Dec 13, 2006
  2. Johannes SchindelinDec 13, 2006
  3. Shawn PearceDec 13, 2006
  4. Johannes SchindelinDec 13, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.