git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: recur status on linux-2.6

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 18, 2006, 10:00 UTC
Message-ID
<Pine.LNX.4.63.0608181155130.28360@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<7vwt96d6s1.fsf@assigned-by-dhcp.cox.net>
Hi,
On Thu, 17 Aug 2006, Junio C Hamano wrote:
Show 31 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Sun, 13 Aug 2006, Junio C Hamano wrote:
> >
> >> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> >> 
> >> > I fail to see how this is worse than -recursive...
> >> 
> >> These are what I got.  ls-files -u output followed by git diff.
> >
> > I am a little confused here: I thought it would be enough to compare the 
> > outputs of "git-ls-files --stage". But that seems wrong.
> >
> > What are the stages for, again?
> 
> I do not offhand remember what git-merge-recursive and
> git-merge-recur store in stage #1 when they recurse to create a
> virtual common ancestor.  I expected it would contain the blob
> used as the base for the final file-level three-way merge
> (i.e. the blob in the virtual common ancestor), and if that is
> the case, i.e. if the blob matches the second argument for
> "merge" (from RCS), it should be enough to check that the stages
> match to verify two implementations do the same thing.
> 
> But in practice, stage #1 is not very interesting nor useful
> after a conflicted merge (git diff --ours and git diff --theirs
> are more useful, so is git log -p --merge), so it is possible
> that merge-recursive is leaving the blob from one of the true
> common ancestors there while using the blob from the virtual
> common ancestor to produce the final result in the working tree
> and nobody has noticed.  I dunno.
Makes sense.

I finally got around to do updated tests, with both git-ls-files --stage and "git diff". It seems like the only issue in the git repository _is_ 10a6653c8. I have not yet had the time to analyze this merge (it is huge!), but I guess recur becomes confused by the timestamps.

Ciao, Dscho

Previous: Junio C HamanoNext: Fredrik Kuivinen
Message 7 of 10 in “recur status on linux-2.6”
  1. Johannes SchindelinAug 13, 2006
  2. Junio C HamanoAug 13, 2006
  3. Johannes SchindelinAug 13, 2006
  4. Junio C HamanoAug 13, 2006
  5. Johannes SchindelinAug 13, 2006
  6. Junio C HamanoAug 18, 2006
  7. Johannes SchindelinAug 18, 2006
  8. Fredrik KuivinenAug 19, 2006
  9. Junio C HamanoAug 22, 2006
  10. Johannes SchindelinAug 22, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.