git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 19/28] makes finish_pack void

From
DRDavid Rientjes <rientjes@google.com>
Date
Aug 14, 2006, 20:35 UTC
Message-ID
<Pine.LNX.4.63.0608141334170.19383@chino.corp.google.com>
Makes finish_pack void and cleans up function calls.
		David
Signed-off-by: David Rientjes <rientjes@google.com>
---
 fetch-clone.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fetch-clone.c b/fetch-clone.c
index 5e84c46..72750c4 100644
--- a/fetch-clone.c
+++ b/fetch-clone.c
@@ -4,7 +4,7 @@ #include "pkt-line.h"
 #include <sys/wait.h>
 #include <sys/time.h>
 
-static int finish_pack(const char *pack_tmp_name, const char *me)
+static void finish_pack(const char *pack_tmp_name, const char *me)
 {
 	int pipe_fd[2];
 	pid_t pid;
@@ -87,7 +87,6 @@ static int finish_pack(const char *pack_
 		 "%s/pack/pack-%s.idx", get_object_directory(), hash);
 	move_temp_to_file(idx, final);
 	chmod(final, 0444);
-	return 0;
 
  error_die:
 	unlink(idx);
@@ -297,5 +296,6 @@ int receive_keep_pack(int xd[2], const c
 		}
 	}
 	close(ofd);
-	return finish_pack(tmpfile, me);
+	finish_pack(tmpfile, me);
+	return 0;
 }
-- 
1.4.2.g89bb-dirty
Message 1 of 1 in “makes finish_pack void”
  1. 19/28 makes finish_pack voidDavid Rientjes, Aug 14, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.