git/list[1] front-page[2] threads[3] people[4] search[5] about
 

PATCH [12/28] makes generate_tar void

From
DRDavid Rientjes <rientjes@google.com>
Date
Aug 14, 2006, 20:29 UTC
Message-ID
<Pine.LNX.4.63.0608141328190.19383@chino.corp.google.com>
Makes generate_tar void and removes conditional return.
		David
Signed-off-by: David Rientjes <rientjes@google.com>
---
 builtin-tar-tree.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin-tar-tree.c b/builtin-tar-tree.c
index 215892b..42230f6 100644
--- a/builtin-tar-tree.c
+++ b/builtin-tar-tree.c
@@ -308,7 +308,7 @@ int git_tar_config(const char *var, cons
 	return git_default_config(var, value);
 }
 
-static int generate_tar(int argc, const char **argv, const char *prefix)
+static void generate_tar(int argc, const char **argv, const char *prefix)
 {
 	unsigned char sha1[20], tree_sha1[20];
 	struct commit *commit;
@@ -354,7 +354,6 @@ static int generate_tar(int argc, const 
 	write_trailer();
 	free(buffer);
 	free(current_path.buf);
-	return 0;
 }
 
 static const char *exec = "git-upload-tar";
@@ -409,7 +408,8 @@ int cmd_tar_tree(int argc, const char **
 		usage(tar_tree_usage);
 	if (!strncmp("--remote=", argv[1], 9))
 		return remote_tar(argc, argv);
-	return generate_tar(argc, argv, prefix);
+	generate_tar(argc, argv, prefix);
+	return 0;
 }
 
 /* ustar header + extended global header content */
-- 
1.4.2.g89bb-dirty
Message 1 of 1 in “PATCH [12/28] makes generate_tar void”
  1. David RientjesAug 14, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.