Re: [PATCH] pager: config variable pager.program
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 31, 2006, 12:56 UTC
- Message-ID
- <Pine.LNX.4.63.0607311454040.29667@wbgn013.biozentrum.uni-wuerzburg.de>
- In-Reply-To
- <E1G7WfC-000728-9j@moooo.ath.cx>
Hi,
On Mon, 31 Jul 2006, Matthias Lederhofer wrote:
> Signed-off-by: Matthias Lederhofer <matled@gmx.net>
The commit message no longer reflects what the patch does ;-)
> - const char *pager = getenv("PAGER");
> + char *pager;You do not need to lose the "const" (it means that you cannot access the memory it points to, but you can change the pointer). Also, you could make a more minimal patch by replacing PAGER by GIT_PAGER here, instead of having this extra line:
> + pager = getenv("GIT_PAGER");Ciao, Dscho