Re: [PATCH] Make git-mv a builtin

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 26, 2006, 10:19 UTC
Message-ID: <Pine.LNX.4.63.0607261204020.29667@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vk660udcn.fsf@assigned-by-dhcp.cox.net>

Hi,

On Tue, 25 Jul 2006, Junio C Hamano wrote:

Show 8 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > This also moves add_file_to_index() to read-cache.c. Oh, and while
> > touching builtin-add.c, it also removes a duplicate git_config() call.
> 
> I'd have preferred to see this not depend on uncooked
> merge-recur infrastructure, since it is very likely that this
> would be ready to graduate to "master" before merge-recur.

I use "next" to base all my work (git or otherwise) on, and forgot that path-list did not yet make it into "master". Sorry.

> I've branched from "master" and placed the path-list stuff which
> was split out of the merge-recur WIP, and applied this patch
> with some trivial adjustment, and will place it on "pu", so I'd
> appreciate if you can double check the result.

Looks good from what I see. BTW do you have any indent command line you prefer? I see that all changes but in the usage string (which was my fault: thank you), and in Makefile (putting path-list into libgit.a rather than linking it specifically), are white space changes.

> > diff --git a/builtin.h b/builtin.h
> > index 5339d86..6f3a439 100755
> 
> Huh -- 100755?

A mistake introduced on cygwin. Again, sorry.

Ciao, Dscho