Re: [PATCH] Eliminate Scalar::Util usage from private-Error.pm

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 26, 2006, 02:25 UTC
Message-ID: <Pine.LNX.4.63.0607260416070.29667@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <20060726021058.GV13776@pasky.or.cz>

Hi,

On Wed, 26 Jul 2006, Petr Baudis wrote:

Show 10 quoted lines

>   Hi,
> 
> Dear diary, on Wed, Jul 26, 2006 at 04:01:03AM CEST, I got a letter
> where Johannes Schindelin <Johannes.Schindelin@gmx.de> said that...
> 
> > - It is not at all easy to run git (Perl scripts) in-place. At least for 
> >   Python, you can set a variable in config.mak and be done with it.
> 
>   Does setting prefix to the same directory as where your Git tree is
> help?

Nope. The culprit is

use lib (split(/:/, $ENV{GITPERLLIB} || "/Library/Perl/darwin"));

The latter, /Library/Perl/darwin comes from making "instlibdir" in perl/, which in turn is generated by "perl Makefile.PL". Calling the latter with PREFIX set does not change the output of "instlibdir" in any way.

Show 10 quoted lines

> > - private_Error.pm is not used. I had to rename it for Error.pm to be
> >   picked up.
> 
>   Hmm, yes, I guess it is copied in place only during the installation.
> We might add something like
> 
> 	all:
> 		cp private-Error.pm blib/lib/Error.pm
> 
> to the perl/Makefile. Opinions?

This (from Makefile.PL) is already sufficient:

# We come with our own bundled Error.pm. It's not in the set of default
# Perl modules so install it if it's not available on the system yet.
eval { require Error };
if ($@) {
        $pm{'private-Error.pm'} = '$(INST_LIBDIR)/Error.pm';
}

> > - It even passes t7001 now. _After_ I spent two hours rewriting it in C.
> 
>   Thanks for the patience - I hope we will finally get all the remaining
> Perl problems sorted out.

What patience? Ah yes, I understand: irony.

Seriously, I still believe that proof-of-concepts in Bash or Perl or even Python are fine. But they are not for real work, so one of my long-term goals for git is to get rid of them.

Ciao, Dscho