Re: [PATCH 2nd try] Make git-fmt-merge-msg a builtin

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 4, 2006, 07:50 UTC
Message-ID: <Pine.LNX.4.63.0607040948170.29667@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vwtaunwj1.fsf@assigned-by-dhcp.cox.net>

Hi,

On Mon, 3 Jul 2006, Junio C Hamano wrote:

Show 10 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> >
> > ---
> > 	This retires git-fmt-merge-msg.perl, since it passes all the
> > 	tests, but removes the Perl version not now.
> 
> There is no point not removing the script if you update git.c
> and Makefile to point at the new one.

I should have put PATH/RFC. I did not want to remove the script right away, so people could compare outputs (like Martin did with git-format-patch).

> We do not have a test specific for fmt-merge-msg, so it
> obviously passes all the tests ;-).  A new one is attached.

Well, t4013 showed me two output bugs, but it evidently did not check for merge.summary.

> I think we should extend boolean to accept 'yes' and 'no',

In that case, could we have "YesPlease", "oui", "si" and "da", too? ;-)

Ciao, Dscho